fix: fix test_element_type test #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMichka
force-pushed
the
vector2
branch
2 times, most recently
from
9d23c2a to
4083b7a
Compare
iMichka
force-pushed
the
vector2
branch
3 times, most recently
from
e3eb710 to
3ae7e0e
Compare
In some rare cases the find_value_type function would find multiple declarations. The logic in the function prevented to return the right value type, so I inverted it which fixes one more test on macOS Fixes: FAILED tests/test_vector_traits.py::test_element_type - RuntimeError: Unable to find out vector '::std::vector<std::wstring>' key\value type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.